Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto update sphinx theme css files #291

Merged
merged 2 commits into from
Apr 2, 2025
Merged

Auto update sphinx theme css files #291

merged 2 commits into from
Apr 2, 2025

Conversation

unidevel
Copy link
Contributor

@unidevel unidevel commented Feb 11, 2025 •
edited
Loading

This PR will update the siteConfig.js automatically.
Also no need to replace @support in the css file manually.

Address the issue in step 5 => https://github.com/prestodb/presto/wiki/Stable-release-process-(every-2-months)#step-5-publish-docs-website

To make auto fix when commit working, please run

cd website; yarn install

Then commit the newly added css files.

Usually when developer test the doc generation locally before commit, the siteConfig.js will be auto fixed.

Also provide the manual comamnd update siteConfig.js

cd website; yarn update-site-config

@unidevel
Copy link
Contributor Author

@ZacBlanco @wanglinsong can you help to review this PR, thanks.

@unidevel unidevel requested a review from ZacBlanco March 10, 2025 19:08
@unidevel
Copy link
Contributor Author

@ZacBlanco @wanglinsong seems I don't have access to merge PR, can you help to merge this PR, thanks.

@wanglinsong wanglinsong requested a review from alileclerc March 12, 2025 16:59
@unidevel unidevel mentioned this pull request Mar 13, 2025
Merged
6 tasks
@unidevel
Copy link
Contributor Author

unidevel commented Mar 14, 2025 •
edited
Loading

Validated by the new release action =>https://github.com/unix280/presto/actions/runs/13844025717/job/38739241705#step:8:21

Found CSS files: [
  '    "static/sphinx_immaterial_theme.359ec555e2989f00f.min.css",',
  '    "static/sphinx_immaterial_theme.37dfeca1a5899a14e.min.css",',
  '    "static/sphinx_immaterial_theme.8bc14be58eddc636f.min.css",'
]

Auto added the css files and updated with the script in @tdcmeehan 's release doc

sed -ibak -e 's/@supports selector(.*11\.5rem)}}//' website/static/docs/current/_static/sphinx_immaterial_theme.*.css

@unidevel unidevel mentioned this pull request Mar 28, 2025
Open
6 tasks
wanglinsong
wanglinsong requested changes Apr 1, 2025
View reviewed changes
Copy link
Member

@wanglinsong wanglinsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also generate package-lock.json file and check it in.

website/updateSiteConfig.js Outdated
process.exit(0);
}

updateSphinxThemeFiles().catch(console.error);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a newline.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@unidevel unidevel force-pushed the auto_update_theme_files branch from 4379a97 to f0beb13 Compare April 2, 2025 07:07
@unidevel
Copy link
Contributor Author

unidevel commented Apr 2, 2025

Please also generate package-lock.json file and check it in.

Since we are using yarn in the github action, I generated yarn.lock instead of package-lock.json

prestodb.github.io/.github/workflows/publish.yml

Line 19 in f72b3e1

run: cd website && yarn install && yarn build

@unidevel unidevel requested a review from wanglinsong April 2, 2025 07:10
wanglinsong
wanglinsong approved these changes Apr 2, 2025
View reviewed changes
Copy link
Member

@wanglinsong wanglinsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wanglinsong wanglinsong merged commit 8f81822 into prestodb:source Apr 2, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZacBlanco ZacBlanco ZacBlanco approved these changes

@wanglinsong wanglinsong wanglinsong approved these changes

@alileclerc alileclerc Awaiting requested review from alileclerc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@unidevel @ZacBlanco @wanglinsong